Skip to content

allow for compile switch overrides - #11773

Merged
Richard Knoll (riknoll) merged 1 commit into
masterfrom
dev/riknoll/compile-switches
Nov 19, 2026
Merged

Richard Knoll (riknoll) merged 1 commit into
masterfrom
dev/riknoll/compile-switches

Conversation

@riknoll

Copy link
Copy Markdown
Member

forgot to add the compile switches to the get extension info api in backendutils

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The compile-switch override change has no active review issues.

No open issues 🎉

What changed in this PR

Adds compile-switch overrides to the shared extension-info API so backend callers can use request-specific settings instead of target defaults.

Changes:

  • Adds an optional compileSwitches argument to getExtensionInfo, preserving default behavior when omitted.
  • Updates CLI tests to pass request switches and verify overrides, empty overrides, cache behavior, and input immutability.
File Description
tests/​cli-test/​clirunner.ts Updates API calls and adds regression coverage for compile-switch overrides.
pxtlib/​shared/​extensioninfo.ts Accepts and copies optional compile switches; documents their replacement behavior.

Review effort: Balanced

@riknoll
Richard Knoll (riknoll) added this pull request to the merge queue Nov 19, 2026
Merged via the queue into master with commit 19bd210 Nov 19, 2026
21 checks passed
@riknoll
Richard Knoll (riknoll) deleted the dev/riknoll/compile-switches branch November 19, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants