Repository navigation
fix(shard): fail when no tests match across all shards - #43173
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoOct 6, 2026
Merged
Conversation
Since v1.31, sharding happens before the "No tests found" check, so the check was skipped for any sharded run. A bad testDir, grep or file filter passed silently. Now the check uses the test count before sharding, so an empty shard still passes while an empty run fails. Fixes: microsoft#43128
Pavel Feldman (pavelfeldman)
force-pushed
the
fix-43128
branch
from
October 6, 2026 20:44
381fbf5 to
40d46e7
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"6 flaky52686 passed, 1270 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 9034 passed, 1495 skipped Merge workflow run. |
Contributor
🟢 Playwright bot: this is a pre-existing flakeThe only real failure is unrelated to this PR. The same DetailsOverall assessment This PR only changes test-runner sharding and its tests. It does not reach the MCP annotation flow, browser dashboard, or navigation path involved in the failure. The six retry-rescued tests in the Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
Yury Semikhatsky (yury-s)
approved these changes
Oct 6, 2026
Pavel Feldman (pavelfeldman)
merged commit Oct 6, 2026
4dd2a65
into
microsoft:main
44 of 45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testDir,--grepor file filter passed silently.Fixes #43128