Skip to content

Revert "fix(blob): do not remove existing reports from output dir" - #43163

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
revert-43056-fix-43013
Oct 6, 2026
Merged

Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
revert-43056-fix-43013

Conversation

@yury-s

Copy link
Copy Markdown
Member

Reverts #43056

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 4c08572 into main Oct 6, 2026
42 of 43 checks passed
@pavelfeldman
Pavel Feldman (pavelfeldman) deleted the revert-43056-fix-43013 branch October 6, 2026 19:05
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 flaky ⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

52642 passed, 1270 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-core.spec.ts:57 › click link @mcp-windows-latest-firefox

9034 passed, 1495 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🟢 Playwright bot verdict: the failure is a pre-existing flake — this PR is clear

This PR only reverts blob-reporter output-directory handling. The failing MCP test does not exercise that code, and its Windows/Firefox timeout is already documented across unrelated runs.

Details

Overall: the only real failure is the MCP click link test on Windows Firefox. The two library results are retry-rescued flakes, so they do not affect this verdict. Nothing in the three-file blob-reporter diff reaches MCP click dispatch or Firefox navigation.

Pre-existing flake / infra

  • [firefox] › mcp/cli-core.spec.ts:57 › click link (mcp-windows-latest-firefox) — the click timed out after 5000 ms while Firefox was performing the action on <a href="/hello-world">, exactly matching the known flake documented in fix(test): unflake MCP cli-core 'click link' on Firefox #42306. Its aggregated history there shows 24 failures in 584 runs (~4%), all with the same click-action timeout, including unrelated runs such as 30014511758 and 30046492910. This PR changes only packages/playwright/src/reporters/blob.ts, its tests, and reporter documentation, so it cannot cause this MCP/Firefox timing race.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants