Repository navigation
test(client-certificates): accept 503 when server resets after handshake - #43147
Merged
Dmitry Gozman (dgozman) merged 1 commit intoOct 6, 2026
Conversation
The server's rejection of the client certificate after the TLS 1.3 handshake arrives at the proxy either as a clean close or as ECONNRESET, depending on timing and platform. The latter makes the proxy serve its 503 error page, so the test should accept both outcomes.
Contributor
Test results for "tests 1"6 flaky52640 passed, 1270 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 9034 passed, 1495 skipped Merge workflow run. |
Contributor
|
Hi, I'm the Playwright bot and I took a first look at the CI failure. 🟢 The failure is a confirmed pre-existing MCP flakeThe failing download test is unrelated to this PR's client-certificate assertion change and has failed on an unrelated PR before. DetailsOverall: this PR only changes Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
Pavel Feldman (pavelfeldman)
approved these changes
Oct 6, 2026
Dmitry Gozman (dgozman)
merged commit Oct 6, 2026
117d0a5
into
microsoft:main
44 of 45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ECONNRESET, depending on timing and platform.ECONNRESETthe proxy serves its 503 "client-certificate error" page, which is what the Windows and x64 macOS bots hit, so the test added in fix(client-certificates): finish browser TLS handshake before closing on server close #43133 now accepts both outcomes.