Skip to content

feat(webkit): roll to r2361 - #42634

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
roll-into-pw-webkit/2361
Sep 9, 2026
Merged

Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
roll-into-pw-webkit/2361

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/50445f32fd98c5e19d1fdd3ee37b8e7af336bdda. Build has full platform coverage - check that all tests pass there.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium-library] › library/video.spec.ts:113 › screencast › should capture static page `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-goto.spec.ts:90 › should work with Cross-Origin-Opener-Policy `@firefox-ubuntu-22.04-node20`

51409 passed, 1240 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

8348 passed, 1376 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

1 fatal errors, not part of any test
1 failed
❌ [android-page] › page/page-click-scroll.spec.ts:160 › should scroll instantly on retry when scroll-behavior is smooth

40 flaky ⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@tracing-chromium`
⚠️ [chromium-library] › library/client-certificates.spec.ts:364 › browser › should fail with no client certificates `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:607 › run-server › should save download `@msedge-windows-latest`
⚠️ [chromium-library] › library/chromium/extensions.spec.ts:105 › MV3 › should give access to the service worker when recording video `@msedge-windows-latest`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:2474 › should filter actions `@chrome-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/trace-viewer-scrub.spec.ts:177 › should drag scrubber to select action `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:1086 › cli codegen › should record when fullscreen element is open `@chrome-macos-latest`
⚠️ [chromium-library] › library/inspector/console-api.spec.ts:54 › should support playwright.locator.values `@chrome-macos-latest`
⚠️ [chromium-library] › library/inspector/pause.spec.ts:95 › pause › should resume from console `@chrome-macos-latest`
⚠️ [chromium-library] › library/inspector/pause.spec.ts:169 › pause › should disable timeout on paused actions `@chrome-macos-latest`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:75 › selector generator › should generate text for `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:121 › selector generator › should fall back to nth when name and description are both not unique `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:175 › selector generator › should not improve guid text `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:195 › selector generator › should not use text for select `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:467 › selector generator › should match in deep shadow dom `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:516 › selector generator › should work with tricky attributes `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:564 › selector generator › should ignore empty role for candidate consideration `@chrome-macos-latest`
⚠️ [chromium-library] › library/video.spec.ts:326 › screencast › should capture css transformation `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:208 › should print context options method override in mstest if options were passed `@firefox-macos-15-large`
⚠️ [firefox-page] › page/page-goto.spec.ts:90 › should work with Cross-Origin-Opener-Policy `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:813 › launchServer › should upload a folder `@tracing-webkit`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1987 › canvas disabled title `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:2668 › should replace meta content attr that specifies charset `@webkit-macos-15-xlarge`
⚠️ [webkit-page] › page/page-leaks.spec.ts:136 › expect should not leak `@webkit-macos-15-xlarge`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:356 › page screenshot › should work for canvas `@webkit-macos-15-xlarge`

110754 passed, 4725 skipped


Merge workflow run.

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 4b827e3 into main Sep 9, 2026
73 of 75 checks passed
@pavelfeldman
Pavel Feldman (pavelfeldman) deleted the roll-into-pw-webkit/2361 branch September 9, 2026 14:41
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot — I triaged the CI failures on this WebKit roll.

🟢 CI is clear — the one real failure is pre-existing, unrelated to this roll

The only non-flaky failure is an android-page test, and this PR just bumps the WebKit revision (2360 → 2361) in browsers.json. Android runs against Android Chrome, so a WebKit roll can't reach it. The test's history confirms it: it's red on push builds and other PRs too, including this PR's own base SHA.

Details

The diff is a one-line WebKit revision bump in packages/playwright-core/browsers.json. Nothing here touches the android code path, the click/scroll logic, or Chromium.

Pre-existing flake / infra

  • [android-page] › page/page-click-scroll.spec.ts:160 › should scroll instantly on retry when scroll-behavior is smooth — pre-existing, consistently broken on android. In the test-results DB the android bot has 0 passes and 5 failures for this test, on SHAs the PR can't be responsible for: push builds (8c2234cd, 4302dbb9 — this PR's own base — and 5ea7ac2c) and a separate PR feat(firefox): roll to r1544 #42631. It never passed on android, so this is a standing android failure, not something the roll introduced. The accompanying "1 fatal errors, not part of any test" is on the same android run and shares that fate.

  • The 8 + 40 "flaky" entries across chromium/firefox/webkit all passed on retry and are the usual suspects (video.spec.ts screencast, browsercontext-cookies-third-party.spec.ts Partitioned cookies, oopif/service-worker, trace-viewer scrub, page-leaks). Nothing that trends with a WebKit revision bump.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant