Skip to content

fix(network): do not add missing headers when looking them up #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pavel Feldman (pavelfeldman) merged 2 commits into from
Oct 13, 2026
Merged

fix(network): do not add missing headers when looking them up #3246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
227d069
fix(network): do not add missing headers when looking them up
pavelfeldman Oct 12, 2026
6b3a7c9
test: fold the missing header check into the existing test
pavelfeldman Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions playwright/_impl/_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import json as json_utils
import mimetypes
import re
from collections import defaultdict
from pathlib import Path
from types import SimpleNamespace
from typing import (
Expand Down Expand Up @@ -1031,9 +1030,10 @@ def _on_close(self) -> None:
class RawHeaders:
def __init__(self, headers: HeadersArray) -> None:
self._headers_array = headers
self._headers_map: Dict[str, Dict[str, bool]] = defaultdict(dict)
self._headers_map: Dict[str, Dict[str, bool]] = {}
for header in headers:
self._headers_map[header["name"].lower()][header["value"]] = True
values = self._headers_map.setdefault(header["name"].lower(), {})
values[header["value"]] = True

@staticmethod
def _from_headers_dict_lossy(headers: Dict[str, str]) -> "RawHeaders":
Expand All @@ -1047,7 +1047,7 @@ def get(self, name: str) -> Optional[str]:
return separator.join(values)

def get_all(self, name: str) -> List[str]:
return list(self._headers_map[name.lower()].keys())
return list(self._headers_map.get(name.lower(), {}).keys())

def headers(self) -> Dict[str, str]:
result = {}
Expand Down
3 changes: 3 additions & 0 deletions tests/async/test_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,9 @@ async def test_response_headers_should_work(page: Page, server: Server) -> None:
assert response
assert response.headers["foo"] == "bar"
assert (await response.all_headers())["foo"] == "bar"
# Looking up a missing header must not add it.
assert await response.header_value("x-missing") is None
assert "x-missing" not in await response.all_headers()


async def test_request_post_data_should_work(page: Page, server: Server) -> None:
Expand Down
Loading