Repository navigation
fix(network): do not add empty entries to headers when looking up a missing header - #3243
Closed
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Conversation
…issing header RawHeaders.get_all indexed a defaultdict, which inserted an empty entry for every missing name. A later all_headers() then returned that name with a None value.
Member
|
Please remove the tests and add use case to an existing test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response.header_value("x-missing")returnedNonebut left anx-missing: Noneentry behind, so a laterall_headers()listed it.RawHeaders.get_allindexed itsdefaultdict, which inserts on every miss. It now uses.get(name, {}), so lookups no longer change the headers. Async and sync tests cover the lookups on bothResponseandRequest.Fixes microsoft/playwright#43306