Repository navigation
feat(junit): add Browser.NewContextOptions fixture - #2005
Merged
Merged
Conversation
Yury Semikhatsky (yury-s)
marked this pull request as ready for review
October 14, 2026 21:47
| contextOptions.setBaseURL(options.baseUrl); | ||
| } | ||
|
|
||
| if (options.deviceName != null) { |
There was a problem hiding this comment.
Assert browser type.
Member
Author
There was a problem hiding this comment.
Done in decf3d4: setting both deviceName and a browserName that differs from the device's defaultBrowserType now throws. With only deviceName set, the browser is already taken from the device.
Pavel Feldman (pavelfeldman)
approved these changes
Oct 14, 2026
Yury Semikhatsky (yury-s)
merged commit Oct 15, 2026
2aa1a2b
into
microsoft:main
18 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@UsePlaywrightcan now injectBrowser.NewContextOptions, configured from theOptionsFactorythe same way as theBrowserContextfixture.@BeforeAll/@AfterAll, so class-level setup can create its own context.Fixes #1781