Avoid over-allocation for naturally aligned requests - #1408
Open
Connor Tsui (connortsui20) wants to merge 1 commit into
Open
Connor Tsui (connortsui20) wants to merge 1 commit into
Connor Tsui (connortsui20) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids over-allocation for requests smaller than their alignment by using a naturally aligned size class up to 4 KiB.
The size adjustment applies only to unpadded, zero-offset requests, preserving byte-precise overflow checks.
It also accepts alignments below 4 KiB for block sizes that are multiples of 4 KiB.
Backing block sizes in bytes:
(size, alignment)(64,256)(1,4096)(8192,32)(65536,256)(65536,4096)Related: vortex-data/vortex#9812