Repository navigation
Keep hierarchy nodes after partial folder deletion - #1025
Merged
Stephen Griffin (stephenegriffin) merged 2 commits intoOct 21, 2026
Merged
Conversation
Remove a folder node only when DeleteFolder returns S_OK. Partial-completion warnings do not establish that the folder itself was deleted; retain the existing error reporting and node in that case. Fixes #655. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Stephen Griffin (stephenegriffin)
enabled auto-merge (squash)
October 21, 2026 16:47
bwittgen
approved these changes
Oct 21, 2026
Stephen Griffin (stephenegriffin)
deleted the
fix/655-partial-folder-deletion
branch
October 21, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #655.
DeleteFolderreturnsS_OK, rather than for everySUCCEEDEDresult.MAPI_W_PARTIAL_COMPLETIONand other success-status warnings: partial completion does not establish that the folder itself was deleted.The branch already includes current
main; the PR diff is limited to the result guard and its comment.Validation
S_OK,MAPI_W_PARTIAL_COMPLETION,S_FALSE, failure, access denied, and cancellation. These are decision checks, not persistent native UI regression coverage.