Skip to content

Normalize error values before selecting a property editor - #1024

Merged
Stephen Griffin (stephenegriffin) merged 5 commits into
mainfrom
fix/854-guid-editor-error-values
Oct 21, 2026
Merged

Stephen Griffin (stephenegriffin) merged 5 commits into
mainfrom
fix/854-guid-editor-error-values

Conversation

@stephenegriffin

Copy link
Copy Markdown
Member

Summary

Fixes #854.

  • Normalize fetched and caller-supplied property values together before selecting an editor, preventing a returned PT_ERROR value from being interpreted as a GUID pointer.
  • Treat MAPI_E_NOT_FOUND for a requested non-error type as missing input so the requested property can be created; otherwise select the actual returned property type.
  • Retain fetched-property ownership until the dialog workflow completes and preserve caller ownership of supplied values.
  • Include the latest main. The diff against main is limited to property input normalization and its clang-format 17 formatting.

Validation

  • Existing Debug x64 and x86 build tasks pass with no warnings or errors.
  • Complete existing native suites pass: 261/261 on x64 and 261/261 on x86.
  • All 433 CI-checked C/C++ files pass clang-format 17 using the workflow's options.
  • The existing unit-test project does not exercise this editor-selection path. Follow-up Expand native test coverage to property editors and multivalue row editing #1022 now explicitly includes Access Violation when Editing a PT_CLSID Property #854 regression cases for input normalization, editor selection, supplied/fetched values, and ownership on acceptance/cancellation. Earlier local source-extracted policy checks are not claimed as persistent native regression coverage.

Apply the same input handling to fetched and caller-supplied properties. Preserve creation of missing typed properties and use PT_ERROR for other returned errors rather than reading their union as a GUID or another requested type.

Fixes #854.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Test Results

    8 files  ±0      8 suites  ±0   54s ⏱️ ±0s
  261 tests ±0    261 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 088 runs  ±0  2 088 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d3b2953. ± Comparison against base commit 7f1fdb8.

♻️ This comment has been updated with latest results.

@stephenegriffin
Stephen Griffin (stephenegriffin) merged commit 2c59cc7 into main Oct 21, 2026
21 checks passed
@stephenegriffin
Stephen Griffin (stephenegriffin) deleted the fix/854-guid-editor-error-values branch October 21, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Access Violation when Editing a PT_CLSID Property

2 participants