Skip to content

Fix accepting unchanged multivalue property rows - #1023

Merged
Stephen Griffin (stephenegriffin) merged 2 commits into
mainfrom
fix/612-empty-mv-string
Oct 21, 2026
Merged

Stephen Griffin (stephenegriffin) merged 2 commits into
mainfrom
fix/612-empty-mv-string

Conversation

@stephenegriffin

Copy link
Copy Markdown
Member

Summary

Fixes #612.

  • Serialize accepted multivalue rows even when their contents have not changed. An untouched empty string row must return a typed, terminated value instead of leaving the output uninitialized for the caller.
  • Preserve the existing early return for unchanged ordinary (non-MV-row) properties.
  • Merge the latest main into the fix branch before submission. The diff against main remains limited to the serialization guard and its comment.

Validation

  • Existing Debug x64 and x86 build tasks pass with no warnings or errors.
  • Complete existing native suites pass: 261/261 on x64 and 261/261 on x86 after merging main.
  • Earlier focused policy checks covered the four dirty/unchanged and MV/ordinary combinations. These were local decision checks, not persistent native editor regression tests.
  • The existing unit-test project does not exercise the property-editor UI. Follow-up Expand native test coverage to property editors and multivalue row editing #1022 tracks expanding the framework to test the actual editor serialization and MV-row handling without interactive dialogs or an installed MAPI provider.

Return a typed value when an MV row is accepted without edits, including newly added empty strings. Preserve the no-change behavior for ordinary property editors.

Fixes #612.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Test Results

    8 files  ±0      8 suites  ±0   41s ⏱️ -9s
  261 tests ±0    261 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 088 runs  ±0  2 088 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit de4883d. ± Comparison against base commit 37f89e8.

@stephenegriffin
Stephen Griffin (stephenegriffin) merged commit b62fff3 into main Oct 21, 2026
20 checks passed
@stephenegriffin
Stephen Griffin (stephenegriffin) deleted the fix/612-empty-mv-string branch October 21, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash adding a 0-size string to a MV_UNICODE prop

3 participants