Repository navigation
Fix table export row indices across query batches - #1021
Merged
Stephen Griffin (stephenegriffin) merged 7 commits intoOct 21, 2026
Merged
Conversation
Keep exported row indices monotonic across QueryRows batches, including short batches. Fixes #882. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Exercise actual XML export across batch boundaries, row payloads, seek and query failures, input preservation, diagnostics, and allocation cleanup. Route only the test exporter's memory calls through the existing MAPI stub seam so both architectures run without initialized native MAPI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Stephen Griffin (stephenegriffin)
enabled auto-merge (squash)
October 21, 2026 15:50
macienMSFT
previously approved these changes
Oct 21, 2026
bwittgen
previously approved these changes
Oct 21, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Stephen Griffin (stephenegriffin)
dismissed stale reviews from bwittgen and macienMSFT
via
October 21, 2026 16:25
f914df0
macienMSFT
approved these changes
Oct 21, 2026
Stephen Griffin (stephenegriffin)
deleted the
fix/882-table-export-row-indices
branch
October 21, 2026 19:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #882.
QueryRowsbatches instead of restarting at zero for each batch.Validation
outputTable,outputProperties,outputSRow, andoutputSRowSeteach improve from 0% to 100% line and block coverage;outputPropertyimproves from 0% to 66.67% line coverage. Across those five production functions, 85/95 lines are fully covered, plus two partially covered lines.