Allow InitializeComponent to have parameters - #1632
Open
Yexuan Xiao (YexuanXiao) wants to merge 3 commits into
Open
Yexuan Xiao (YexuanXiao) wants to merge 3 commits into
Yexuan Xiao (YexuanXiao) wants to merge 3 commits into
Conversation
Contributor
Author
|
Scott Jones (@Scottj1s) Could you review this PR? |
Clarified behavior of InitializeComponent with parameters and its impact on XAML runtime callbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1130 improved InitializeComponent to avoid leading to multiple destructor calls when an exception is thrown, but that patch blocked an important feature: using constructor parameters to initialize XAML elements. I wrote this kind of code back in 2023, when I didn't know about this issue, because the WinUI project template wasn't updated until the end of 2023. Currently, constructor parameters must be saved as members and cannot be naturally passed to InitializeComponent, leads to increased memory usage and performance decrease. This comment also pointed out this issue.