Repository navigation
Make history and memory items clickable on their text - #2518
Open
Mohammad Umer (mohammad19169) wants to merge 1 commit into
Open
Mohammad Umer (mohammad19169) wants to merge 1 commit into
Mohammad Umer (mohammad19169) wants to merge 1 commit into
Conversation
The expression/result TextBlocks in history items and the value TextBlock in memory items had IsTextSelectionEnabled set, so clicks on the text were consumed by text selection and never raised the ListView ItemClick. Only clicks on the surrounding whitespace loaded the item. Disable text selection so clicking anywhere on an item loads it; copying remains available via the context menu.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expression/result TextBlocks in history items and the value TextBlock in memory items had
IsTextSelectionEnabledset, so clicks on the text were consumed by text selection and never raised the ListViewItemClick. Only clicks on the surrounding whitespace loaded the item. Disable text selection so clicking anywhere on an item loads it; copying remains available via the context menu.Description of the changes:
HistoryList.xaml: removedIsTextSelectionEnabled="True"from the expression (HistoryItemExpression) and result (HistoryItemValue) TextBlocks, so clicking the text of a history item loads it into the calculator.MemoryListItem.xaml: removedIsTextSelectionEnabled="True"from the memory value TextBlock (MemoryItemValue), so clicking the value loads the memory item.How changes were validated: