Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/skills/code-review/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ verified. When in doubt, leave it out.

Apply only the checklists for languages that actually changed. Keep findings high-signal.

### C# (`StaticHost`, tools, AppHost — xUnit, `net10.0`, nullable enabled)
### C# (`StaticHost`, tools, AppHost — xUnit, `net11.0`, nullable enabled)

- **Correctness:** middleware ordering and short-circuiting; request/response paths; header and
content-negotiation parsing (`AcceptHeaderParser`, path mapping) handle malformed/edge input.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/frontend-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ jobs:
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: statichost-bin
path: src/statichost/StaticHost/bin/Release/net10.0
path: src/statichost/StaticHost/bin/Release/net11.0
if-no-files-found: error
retention-days: 7

Expand Down Expand Up @@ -455,7 +455,7 @@ jobs:
uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
with:
name: statichost-bin
path: src/statichost/StaticHost/bin/Release/net10.0
path: src/statichost/StaticHost/bin/Release/net11.0

# Any answer, a 404 included, means StaticHost is up and has built its
# routing table, which the first request does.
Expand Down
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "10.0.100",
"version": "11.0.100",
"rollForward": "latestFeature"
}
}
2 changes: 1 addition & 1 deletion src/apphost/Aspire.Dev.AppHost/Aspire.Dev.AppHost.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<AspireUseCliBundle>true</AspireUseCliBundle>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/playwright.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export default defineConfig({
// Build job builds it, so the tests start its assembly directly: `dotnet run --no-build` still
// evaluates the project, which takes seconds. The E2E jobs start it before dist arrives
// (.github/scripts/start-web-server.mjs), hence reuseExistingServer.
command: `dotnet bin/Release/net10.0/StaticHost.dll --urls ${e2eBaseUrl}`,
command: `dotnet bin/Release/net11.0/StaticHost.dll --urls ${e2eBaseUrl}`,
cwd: fileURLToPath(new URL('../statichost/StaticHost/', import.meta.url)),
// No Redis runs with the tests: the short connect timeout keeps StaticHost from waiting 5 s per
// attempt at startup.
Expand Down
10 changes: 5 additions & 5 deletions src/statichost/StaticHost/StaticHost.csproj
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<SelfContained>false</SelfContained>
<PublishAot>false</PublishAot>
<InvariantGlobalization>true</InvariantGlobalization>
<ContainerFamily>noble-chiseled</ContainerFamily>
<ContainerFamily>resolute-chiseled</ContainerFamily>

<!--
SiteFileMiddleware serves the web root, and Site.targets publishes the site to it. Static web
Expand All @@ -22,15 +22,15 @@
<PackageReference Include="Azure.Monitor.OpenTelemetry.AspNetCore" Version="1.4.0" />
<PackageReference Include="Aspire.Azure.Security.KeyVault" Version="13.6.0" />
<PackageReference Include="Aspire.Microsoft.Azure.StackExchangeRedis" Version="13.6.0" />
<PackageReference Include="Microsoft.Extensions.Http.Resilience" Version="10.5.0" />
<PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="10.0.12" />
<PackageReference Include="Microsoft.Extensions.Http.Resilience" Version="11.0.0" />
<PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="11.0.0" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.20.0" />
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.20.0" />
<PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.20.0" />
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.20.0" />
<PackageReference Include="OpenTelemetry.Instrumentation.Runtime" Version="1.20.0" />
<PackageReference Include="Scalar.AspNetCore" Version="2.10.0" />
<PackageReference Include="System.IO.Hashing" Version="10.0.12" />
<PackageReference Include="System.IO.Hashing" Version="11.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/tools/AtsJsonGenerator/AtsJsonGenerator.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<OutputType>Exe</OutputType>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<OutputType>Exe</OutputType>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>annotations</Nullable>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
Expand Down
6 changes: 3 additions & 3 deletions tests/StaticHost.Tests/StaticHost.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<Sdk Name="Aspire.AppHost.Sdk" Version="13.6.0" />

<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
Expand All @@ -17,8 +17,8 @@
<PackageReference Include="Aspire.Hosting.Azure.Redis" Version="13.6.0" />
<PackageReference Include="Aspire.Hosting.Testing" Version="13.6.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.11.0" />
<PackageReference Include="Microsoft.AspNetCore.TestHost" Version="10.0.13" />
<PackageReference Include="Microsoft.Extensions.TimeProvider.Testing" Version="10.5.0" />
<PackageReference Include="Microsoft.AspNetCore.TestHost" Version="11.0.0" />
<PackageReference Include="Microsoft.Extensions.TimeProvider.Testing" Version="11.0.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.1">
<PrivateAssets>all</PrivateAssets>
Expand Down
Loading