Repository navigation
fix(runtime): surface pip bootstrap errors in llm runtime setup - #3253
Merged
Daniel Meppiel (danielmeppiel) merged 1 commit intoOct 16, 2026
Merged
Conversation
`python3 -m venv` captures ensurepip output, so `apm runtime setup llm` failures only reported "returned non-zero exit status 1". Create the venv without pip and bootstrap pip as a visible step that names the python3 in use, so the real cause reaches users and the release-gate CI log. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 761bf207-57da-41d0-bd3f-ffecbb97b83a
Daniel Meppiel (danielmeppiel)
requested a review
from Sergio Sisternes (sergio-sisternes-epam)
as a code owner
October 16, 2026 13:01
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow diagnostic change preserves immediate failure handling, with no blocking issues identified.
0 open findings
What changed in this PR
Improves LLM runtime setup diagnostics to help investigate the release-gate failure remaining after #3251.
Changes:
- Separates virtual environment creation from pip bootstrapping so ensurepip errors remain visible.
- Reports the selected Python executable and exits explicitly when either step fails.
| File | Description |
|---|---|
| scripts/runtime/setup-llm.sh | Adds a visible pip bootstrap step and contextual failure messages. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Daniel Meppiel (danielmeppiel)
deleted the
danielmeppiel/fix-llm-venv-bootstrap
branch
October 16, 2026 13:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
apm runtime setup llmstill fails in the release-gatetest_dual_runtime_installationon Linux arm64/x86_64 and macOS arm64 (dispatch run 38900193538, after #3251) with onlyensurepip ... returned non-zero exit status 1, becausepython3 -m venvcaptures ensurepip's output. It does not reproduce locally with the same CI-built binary.setup-llm.shnow creates the venv with--without-pip, then runsensurepip --upgrade --default-pipas its own visible step and names thepython3in use. Users get the actual cause; the next release-gate dispatch will show it if the failure persists.Issue and approved scope
Issue: N/A -- maintainer-directed CI repair blocking the v0.34.0 release (#3250); follow-up to #3251.
Human scope-approval comment: Daniel Meppiel (@danielmeppiel) directed in-session: "loop and bypass merge PRs until they're fixed and we know that the release workflow would pass".
Does this PR complete the issue, or what remains? Diagnostic + equivalent bootstrap; a post-merge
manual-build-releasedispatch verifies.Type of change
Testing
Tested locally
All existing tests pass
Added tests for new functionality (if applicable)
bash -n scripts/runtime/setup-llm.sh; ran the script twice against a fresh tempHOME-- both exit 0 (fresh and re-run).uv run --extra dev pytest tests/integration/test_tls_r3_verify.py tests/unit -k "llm or setup_llm or runtime"-- pass.Spec conformance (OpenAPM v0.1)
docs/src/content/docs/specs/openapm-v0.1.mdupdated(new/changed
<a id="req-XXX"></a>anchor + prose + Appendix Crow).
docs/src/content/docs/specs/manifests/openapm-v0.1.requirements.ymlupdated.
@pytest.mark.req("req-XXX")test undertests/spec_conformance/added or extended.CONFORMANCE.{md,json}regenerated viauv run --extra dev python -m tests.spec_conformance.gen_statementand committed.