Skip object classification for shared type facts - #64188
Open
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Open
Skip object classification for shared type facts#64188Mateusz Burzyński (Andarist) wants to merge 1 commit into
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Copilot started reviewing on behalf of
Mateusz Burzyński (Andarist)
September 7, 2026 09:30
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The optimization preserves requested type facts while safely avoiding unnecessary member resolution.
Pull request overview
Optimizes type-fact computation by avoiding unnecessary object classification when all object kinds share the requested facts.
Changes:
- Computes facts common to empty, function, and regular objects.
- Returns shared facts early when classification cannot affect the result.
File summaries
| File | Description |
|---|---|
tsc/internal/checker/checker.go |
Adds the shared-fact fast path. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the compiler to skip some work at times. Some of the
isEmptyObjectType,isFunctionObjectTypecalls and alikes performed down the line can be skipped.