Keep portable PIA outputs RID-independent - #1623
Open
Andrew Wang (WardenGnaw) wants to merge 1 commit into
Open
Andrew Wang (WardenGnaw) wants to merge 1 commit into
Andrew Wang (WardenGnaw) wants to merge 1 commit into
Conversation
PR #1610 added MakePIAPortable as a transitive project dependency. Runtime-specific OpenDebugAD7 publishes therefore propagated their RID to the portable PIA projects, relocating their outputs beneath RID subdirectories. Keep these build-only, RID-independent outputs at their established locations so MicroBuild signing accepts PIA\drop and the portable PIA tool remains discoverable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Andrew Wang (WardenGnaw)
September 21, 2026 20:37
View session
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes directly address RID propagation without altering the established build or signing paths.
Review effort: Balanced
Findings: None
What changed in this PR
Keeps portable PIA build artifacts in established RID-independent locations during runtime-specific OpenDebugAD7 publishing.
Changes:
- Disable RID subdirectories for portable PIA outputs.
- Keep the PIA conversion tool at its expected shared path.
| File | Description |
|---|---|
src/MakePIAPortable/MakePIAPortable.csproj |
Preserves the fixed PIA output layout. |
src/tools/MakePIAPortableTool/MakePIAPortableTool.csproj |
Preserves the tool’s discoverable output path. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Andrew Wang (WardenGnaw)
requested a review
from Gregg Miskelly (gregg-miskelly)
September 21, 2026 20:39
Andrew Wang (WardenGnaw)
marked this pull request as ready for review
September 21, 2026 20:39
Gregg Miskelly (gregg-miskelly)
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1610 added MakePIAPortable as a transitive project dependency. Runtime-specific OpenDebugAD7 publishes therefore propagated their RID to the portable PIA projects, relocating their outputs beneath RID subdirectories.
Keep these build-only, RID-independent outputs at their established locations so MicroBuild signing accepts PIA\drop and the portable PIA tool remains discoverable.