Bug 39795650: Make DCR startup state deterministic - #1792
Draft
Mike Thompson (mthompson83) wants to merge 9 commits into
Draft
Mike Thompson (mthompson83) wants to merge 9 commits into
Mike Thompson (mthompson83) wants to merge 9 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 441ffc4e-56a7-490d-9689-12c392813b15
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 441ffc4e-56a7-490d-9689-12c392813b15
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Mike Thompson (mthompson83)
left a comment
Mike Thompson (mthompson83)
left a comment
Author
There was a problem hiding this comment.
This is a partial review.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 441ffc4e-56a7-490d-9689-12c392813b15
Mike Thompson (mthompson83)
left a comment
Mike Thompson (mthompson83)
left a comment
Author
There was a problem hiding this comment.
If there are going to be automated tests, they must be wired in so that they are always run.
The tests may not be needed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 441ffc4e-56a7-490d-9689-12c392813b15
Mike Thompson (mthompson83)
left a comment
Mike Thompson (mthompson83)
left a comment
Author
There was a problem hiding this comment.
More issues
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 441ffc4e-56a7-490d-9689-12c392813b15
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. |
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. |
) * fix: quote ConfigMap-derived environment assignments * Upgrade Linux Telegraf to 1.40.1 Remove the outdated Windows Telegraf update comment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Revert misplaced Telegraf update The Telegraf 1.40.1 bump and Windows note removal belong to PR #1764, not this ConfigMap shell-quoting PR. Reverts commit 44237c6. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Change umask to allow non-owner reading to reduce chance of causing a regression. Change the umask when writing a sensitive file. Change the temp DCR file handling to close a tiny create-but-not cleaned up window.
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DCR_REQUIREDfrom the configuration mode before startup waitsWork item
Validation
This draft is for implementation review. No reviewers are requested yet.