Repository navigation
[HLSL] Add I8/U8 LinAlg descriptor load/store tests - #9058
Merged
Jack Elliott (JoeCitizen) merged 1 commit intoOct 20, 2026
Merged
Jack Elliott (JoeCitizen) merged 1 commit into
Jack Elliott (JoeCitizen) merged 1 commit into
Conversation
The existing I8/U8 multiply tests load 8-bit matrices from descriptors, but no test stores one, and none use column-major or padded 8-bit layouts. - Byte-exact I8/U8 descriptor round trips at Wave (16x32, 32x16 B) and ThreadGroup (32x32 at 128 threads, 64x32 at 256 threads) scope. - Row-major, column-major and row-to-column variants, plus offset and padded-stride layouts. Every byte value appears, so the patterns include -128, -1, 0, 127 and 0, 127, 128, 255. - I8/U8 multiply into I32 with a column-major B at Wave and ThreadGroup scope. All cases are gated on the construction and multiply capability queries. Fixes microsoft#9057 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f05f926c-8544-4ea3-87aa-307088e1622a
Jesse Natalie (jenatali)
approved these changes
Oct 20, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Reported WARP descriptor-view failures need human confirmation of driver attribution and acceptance before merging.
No open issues 🎉
What changed in this PR
Adds I8/U8 LinAlg execution coverage for descriptor stores and layouts, addressing #9057.
Changes:
- Adds byte-exact Wave and ThreadGroup descriptor round trips, including cross-layout and offset/padded cases.
- Adds I8/U8-to-I32 multiplication tests with column-major B matrices.
- Gates cases on construction and multiply capability queries.
| File | Description |
|---|---|
| tools/clang/unittests/HLSLExec/LinAlgTests.cpp | Adds byte-layout helpers, descriptor round trips, and column-major multiply tests. |
Review effort: Balanced
Member
I've reviewed the proposed fix and yes, this is a WARP bug that needs to be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing I8/U8 multiply tests load 8-bit matrices from descriptors, but no test stores one, and none use column-major or padded 8-bit layouts.
All cases are gated on the construction and multiply capability queries. On current WARP the round trips fail through bounds-checked descriptor views (only the first quarter of the buffer is reached) and pass through root views; that's a WARP bug being reported separately.
Fixes #9057