Repository navigation
Test renderWebChat() into a shadow root nested in another shadow root on React 16 - #5991
Merged
Merged
Conversation
Eugene (OEvgeny)
marked this pull request as ready for review
October 30, 2026 20:21
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
Thomas Durnford (tdurnford)
as code owners
October 30, 2026 20:22
William Wong (compulim)
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
No changelog entry: tests only.
Description
Follow-up to #5982, answering whether a shadow root nested in another shadow root trips the React 16 check: it does not, because
ShadowRoot.getRootNode()returns the shadow root itself, and React 16 listens on that inner shadow root.Specific Changes
renderWebChat.spec.tsx: a shadow root nested in another one renders on React 16; an element inside it throwscustomElement/shadowRoot.interact.renderIntoNestedShadowRoot.html: React 16 renders into the inner shadow root, types, sends and clicks a suggested actionI have added tests and executed them locally
I have added
.changelog/<PR#>-<slug>.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed