Skip to content

Test renderWebChat() into a shadow root nested in another shadow root on React 16 - #5991

Merged
Eugene (OEvgeny) merged 2 commits into
mainfrom
OEvgeny/fix-test-nested-shadow-root
Oct 30, 2026
Merged

Eugene (OEvgeny) merged 2 commits into
mainfrom
OEvgeny/fix-test-nested-shadow-root

Conversation

@OEvgeny

Copy link
Copy Markdown
Collaborator

Related to #5982

Changelog Entry

No changelog entry: tests only.

Description

Follow-up to #5982, answering whether a shadow root nested in another shadow root trips the React 16 check: it does not, because ShadowRoot.getRootNode() returns the shadow root itself, and React 16 listens on that inner shadow root.

Specific Changes

  • renderWebChat.spec.tsx: a shadow root nested in another one renders on React 16; an element inside it throws

  • customElement/shadowRoot.interact.renderIntoNestedShadowRoot.html: React 16 renders into the inner shadow root, types, sends and clicks a suggested action

  • I have added tests and executed them locally

  • I have added .changelog/<PR#>-<slug>.md

  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny Eugene (OEvgeny) added the no-changelog No .changelog/ fragment needed (development environment or test-only change) label Oct 30, 2026
@OEvgeny
Eugene (OEvgeny) marked this pull request as ready for review October 30, 2026 20:21
Copilot AI balanced review requested due to automatic review settings October 30, 2026 20:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@OEvgeny
Eugene (OEvgeny) merged commit 91d9f82 into main Oct 30, 2026
45 checks passed
@OEvgeny
Eugene (OEvgeny) deleted the OEvgeny/fix-test-nested-shadow-root branch October 30, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No .changelog/ fragment needed (development environment or test-only change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants