Repository navigation
Experiment: align review gold and compare knowledge with any-match scoring - #983
Draft
Wenjie Fan (gggdttt) wants to merge 13 commits into
Draft
Wenjie Fan (gggdttt) wants to merge 13 commits into
Wenjie Fan (gggdttt) wants to merge 13 commits into
Conversation
Correct four unsupported gold claims, add three source-supported positives, and retain the official one-to-one scoring contract. Record all 97 historical missed-gold dispositions without rescoring or publishing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
Contributor
Code coverage overviewLanguages: Python Python / code-coverage/pytest
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
Reuse one semantic judge pass for two explicit one-to-one assignments. Preserve original all-gold results, summaries, aggregates and historical audit judgments; never filter output by generated severity. Reclassify analyzer-policy and missing-context audit assumptions without silently changing analyzer scoring. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
…time Retain typed compiler/analyzer records, repeatable neutral matching and historical scope sensitivity. Pin the controlled baseline engine and isolate CLI 1.0.88 with explicit auto-update disabling. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
Change only the engine pin and its regression expectation relative to the corrected baseline arm. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
F001 was already matched to Medium G05, not part of the 322 unmatched comments or Low exclusions. Preserve all gold until the complete independent audit adjudicates whether the added functional expectation duplicates G05. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
Keep console and markdown metric help consistent with the approved severity and mechanical neutrality policies. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
Preserve all historical audit identities, apply source-supported gold and neutral-diagnostic repairs, and retain explicit unresolved dispositions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
Change only the engine pin and its regression assertion; keep the corrected dataset, scorer, workflow and runtime identical to the baseline parent. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
Keep runtime artifacts separate from scoring, preserve failure states, and require evidence on successful reviews. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
Change only the transitive engine pin and its workflow-test expectation; preserve identical dataset, scorer and runtime evidence collection. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
Keep all 145 fixtures and 300 gold records unchanged in shape. Narrow two locking claims, remove a duplicate diagnostic citation, and preserve dataset alignment evidence without changing scoring or preparing new evaluation arms. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
Separate comment precision from unique gold coverage, retain legacy scoring on complete semantic edges, and support an unpublished isolated plain-review arm without changing fixtures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
Collect the engine v1 trace with strict bounds and explicit unknown states; keep scorer and frozen fixtures unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cdcfc5b-6707-42d8-9b83-afd27107272f
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current state
Draft, intentionally unmerged and unpublished. User-authorized scoring and isolated-review implementation is complete at
d581548dada27cbab1a54dd38602f9778b638b72. The current experiment is no BCQuality versus narrowed new BCQuality, not original knowledge versus new knowledge. Neither new full evaluation has started; exact-head CI and final launch approval remain required. No additional trials, automatic retries, merges or publication are authorized.The dataset remains byte-identical to
cd148da4dd8247d03bcd73b0f25b1db8359d3322: SHA25642178a85e9e8ce023f32ef030a95f2c2829f76268d47cac47c8beafd577a8a30, 145 entries / 300 records = 235 semantic + 56 analyzer + 9 compiler. Semantic scope is 218 Medium-or-higher and 17 Low. No gold, severity, source fixture, or atomic split was changed by the scoring commit.Implemented scoring contract
specific-site-v2requires the same concrete function/statement/site, supplies start/end ranges and the full source diff with CLI-safe escaped newlines. A CSV-only finding cannot cover the vendor loop.covered_gold_countand preserve complete positive/negative judge-edge evidence. Four views are retained: any-match and legacy one-to-one, each Medium-aligned and all-severity semantic.legacy_resultis legacy assignment on the SAME NEW JUDGE EDGES, not reproduction of the historical judge prompt. Old stored results remain readable as one-to-one/same-issue-v1 and are not rewritten. Mixed scoring identities are rejected.Gold should contain one independent repair obligation, not separately count cause/impact/remedy or repeated descriptions. The read-only 235-gold review's tentative performance-001 projection split remains unapplied because applicability/severity are unresolved. Multi-gold unit fixtures do not add speculative benchmark gold.
Two-arm execution contract
Use this exact Bench commit for both full 145-entry runs,
repeat=1,test-run=false,modified-only=false, modelgpt-5.6-sol, native CLI 1.0.88 with updates disabled, judgegpt-5.3-codex, and Medium output treatment/scoring scope. Always supply nonemptyengine-sha=25817a39a67b9e883f1a8ea9624283ab2b41af9bfor the existing no-publication guard.review-integration=nonebcbench evaluate copilot --category code-review --isolated-reviewgpt-5.6-solreviewer invocationreview-integration=bcqualitybcbench evaluate pr-review25817a39a67b9e883f1a8ea9624283ab2b41af9b-> BCQuality41b0b7a39f890d904fd00f3a5c61582573c9adf8, version 1.9; 19 serialgpt-5.6-lunaleaves plusgpt-5.6-solrootThis is a whole-integration ablation, not proof of the effect of five article edits alone. The audit-derived dataset is not held out; one pair establishes neither significance nor generalization. Dependencies remain unmerged microsoft/BC-ALAgents#83 and microsoft/BCQuality#250. The former nine-article candidate is superseded by the narrowed candidate.
Genuine plain-review isolation
The opt-in path uses disposable HOME/configuration and an environment allowlist, disables custom instructions/hooks/IDE connection, disables all discovered skills, requires an empty plugin inventory and excludes skill/task tools. CLI discovery/disable/version commands were exercised with actual 1.0.88 without model calls. Standard harness defaults are unchanged.
All ten BCApps fixture bases contain
.github/agents. With explicit user approval, only the GitHub-hosted job's disposableGITHUB_WORKSPACE/testbedmay quarantine that exact clean tracked directory outside the checkout. Exact index paths receive temporary skip-worktree flags so ordinarygit diff HEADremains byte-identical, including the final CLI prompt's tool-command path; this is not a display filter.finallyrestores bytes/paths/index flags. Configuration/source manifests and before/isolated/after diff hashes are recorded. Dirty config, unrelated conflicting configuration, live/local checkouts, source contamination and restoration failure fail closed. No user configuration or AL/JSON fixture is deleted.Before/after source inventories and bounded status/usage/provenance are uploaded separately from result JSONL. No raw prompt, environment, transcript or failure text is added. These observations establish configured/discovered sources, not omniscient proof of every model file read. Mock summary is retained only one day: download promptly.
Both runs remain unpublished to Braintrust, Kusto and leaderboard. The plain arm cannot requeue; enabled
repeat=1adds no next round. Report all-selected official metrics and symmetric complete-case sensitivity separately, preserving complete/partial/failed states and unknown failure reasons. Inspect actual output/logs and trace improvements, regressions and granularity/location cases to comments and source before final conclusions.Preserved dataset repair and per-row evidence
The earlier three body-only corrections remain: performance-007's conditional update-lock contention no longer claims all readers block; performance-015 permits modification with
FindSet(false)without invented mandatory per-row network costs or measured speedup; style-016 removes a duplicate AA0216 citation. Counts/kinds/severity/locations/fixtures are unchanged.Prior repairs and retirement evidence remain in those ledgers, including unsafe mandatory ModifyAll advice, internal RecordRef visibility, BOM validation wording, used Err label, Temporary/Pending O365 Contact, and duplicate false-delivery-success gold. These are data adjudications, not blanket validation of unmatched findings.
Historical results are immutable, not the new baseline
Run 39773340119 used Bench
93069371a78fbe9612fa02640b2543b6f56ddd42and old datasetf30803905a7a1235688d151384490ce1f998214d614dea8ad117ed49bbcb39a4. Its 145 result/runtime pairs and summary are preserved: 130 completed / 15 partial engine reviews, 2890 completed / 10 failed process records. Green job/collector status is not full-review completion. Logs did not reveal recoverable failure reasons.Those 495 generated comments are not rescored, overwritten, or used as the new matched baseline. The earlier candidate was never dispatched. Historical run 39616090167 likewise remains 105 TP / 322 unmatched-by-gold FP / 97 FN over 137 completed entries; eight excluded positive entries held 31 additional gold. Historical fixed-assignment sensitivities are not current scores.
Validation
42178a85e9e8ce023f32ef030a95f2c2829f76268d47cac47c8beafd577a8a30.cd148da4CI is not validation of this implementation.See current code-review contract and preserved history. No new evaluation results or improvement claims yet.