Repository navigation
feat(land): a gate loosened so the diff passes needs review, like a weakened test - #159
Merged
Merged
Conversation
…lowered floor counts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR that loosens a gate so its own diff passes (raises a budget, adds an exemption, ignore entry or suppression) now needs review by name, the way a weakened test already does: the rubric's
Testscheck becomesTests and gates.Notes
lens/hooks/demo.tsrenames the line in its sample## Risksections; the lens parses check lines generically.Exercised
forge-land's judge, read-only, from a snapshot of this branch (
new) and of its base (old), on draft sandbox PRs (mgratzer/forge-e2e-sandbox) built for this, each based on a fixture branch holding the gate:new, sandbox#57 (raisesmaxLinesPerFile15 to 20 for the script it grows) → needs review,Tests and gates: gates.json raises maxLinesPerFile from 15 to 20 ..., Where to lookgates.json:2old, sandbox#57 → needs review, underTestsas "loosens the assertion", since the gate there is a test reading the budgetnew, sandbox#58 (adds its new script to anexemptlist) → needs review,Tests and gates: ... bin/titles.js added to the exempt list, Where to lookgates.json:5old, sandbox#58 → needs review, underTests("weakened")new, sandbox#60 (adds its new script to.size-ignore, read by a lint step, no test involved) → needs review,Tests and gates: gate loosened: .size-ignore gains the entry bin/titles.js, Where to look.size-ignore:1old, sandbox#60 → needs review, butTests: ok: caught only by the judgment testnew, sandbox#59 (lowers the budget 15 to 10, removes an exemption) → low risk,Tests and gates: ok (tightened)old, sandbox#59 → low risk,Tests: oknewran on the final wording; feat(review): behavior over mocks, deletable code, and diff size #58newon the commit before it (direction wording only).Testsor the judgment test, so this change makes the catch a named check rather than adding one the base never made.forge-landread-only command indocs/testing.md("Exercise a Skill Change") on sandbox#60, with each snapshot.Plan
Plan as first made (no approver: started unattended by another session with --guard)
Testsrow ofskills/_shared/risk-rubric.mdintoTests and gates, no new row, module or variant. Design: interface is the rubric row and its## Riskline; nothing new is hidden; the decision already lives in theTestsrow.## Riskline per the Issue, sync shared copies, runscripts/check-skills.sh; update the lens demo's sample## Risklines.skills/_shared/risk-rubric.mdand its synced copies,lens/hooks/demo.ts.skills/_shared/review-dimensions.md, left alone).Deviations (as of 14eb2b3):
Closes #157
Risk
Verdict: needs review, judged on 14eb2b3
Where to look (needs review only)
PR body, Notes, Judgment calls: feat(land): a gate loosened so the diff passes needs review, like a weakened test #157 is HITL and the Plan had no approver. Do you accept "moved so more passes" and "tightening" in place of the Issue's "raises" and "lowering"?skills/_shared/risk-rubric.md:13: Gates are judged only "for code this diff adds or changes". Will a judge miss a budget raised in the same PR for code that the diff grows only indirectly, or will it flag unrelated config churn?skills/_shared/risk-rubric.md:54: Does "a record, not a check" still stop a judge from treating a named peer reviewer as clearing the verdict? The removed clause said that outright.lens/hooks/demo.ts:22: The lens demo now printsTests and gates:. Do the lens views that show the Risk section still match a renamed check line, and do they still work on older PRs that sayTests:?