Repository navigation
fix(lens): check off review findings when the skill reports its triage - #153
Merged
Merged
Conversation
The pane listed every reviewer finding as an open checklist item and never closed one in a real run, so it could not say whether a finding was handled. The lens now reads the Fixed and Deferred lines of forge-ship's Review Findings and forge-reflect's Finding Triage, closes the findings, and shows those lines above the checklist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pipeline pane listed every reviewer finding as an open checklist item and never closed one in a real run: only the demo ticked boxes. Looking at a finished session, the pane could not say whether a finding was handled.
The lens now reads the
FixedandDeferredbullets under forge-ship's### Review Findingsor forge-reflect's### Finding Triage, marks the findings done, and prints those lines above the checklist. The lines name no single finding, so all findings close at once and the skill's own words say which Issue a deferred one went to.Changes
parse.triageandmodel.withTriage, applied to a finished turn's answer after its findingsREVIEW FINDINGScheck-lens-contract.tschecks both skills' summary formats against the parser;docs/lens.mdlists the formatNotes
/forge-guardsuggestion after address-pr-feedback.Testing
scripts/check-skills.shprints nothing, Biome is clean,claude plugin testpasses 15 of 15 with a new triage test. Not checked: the pane rendering real triage lines in a live session, andtsc(notsconfig.jsonin this worktree). No change underskills/.