Repository navigation
refactor(skills): move PR state into a script and give each rule one home - #150
Merged
Merged
Conversation
…home Skill prose grew from about 10k to 24k words in six weeks. This trims it to 21.8k and restructures the unattended path. - Add skills/_shared/scripts/pr-state.sh (mergeable, ci-wait, failed-checks, review-wait, reviews, feedback) with fixture tests run by scripts/check-skills.sh. pr-readiness.md now describes outputs and the judgment left to the skill. - Keep vendor specifics out of the core: bot reviewer failure patterns live in the script's REVIEWERS table, Claude Code notes in skills/_shared/runtimes/claude-code.md. - Give each cross-skill rule one home: unattended triage in review-rubric.md, the outcome label and late wake-ups in status-reporting.md, review-ready in guard, merge-ready in land. - Rewrite forge-guard and forge-land as steps and tables. Drop Guidelines sections that restated steps, and barrel-imports.md. Behavior removed on purpose: - No substitute review, retry or partial kind: a failed bot review ends the guard at needs-human. - A wake-up after a terminal state changes nothing and says to re-run forge-guard. - No Revisions block: the PR carries the Plan as last approved. - Land's judge no longer reads REVIEW.md files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill prose more than doubled in six weeks (about 10k to 24k words), mostly in the unattended path, where a state machine was written as prose with pasted shell and the same rules were restated across skills. This restructures that path and trims the rest to 21.8k words.
Notes
skills/_shared/scripts/pr-state.shreads mergeability, CI, reviews and open feedback (bash 3.2 andghonly). The skills are no longer Markdown only;AGENTS.mdanddocs/architecture.mdsay so.needs-human), handling of events after a terminal state (one line saying to re-run/forge-guard), the Plan's Revisions block, andREVIEW.mdreading in land.REVIEWERStable.Exercised
Sandbox
mgratzer/forge-e2e-sandbox, snapshots of this branch (new) and its base 1675f56 (old), same prompts.new,/forge-ship --guard add GET /notes/:id/sentence-count ...→ PR 52,review-ready, land "needs review" (package.jsontouched),deps-auditsorted pre-existing,publish-smokeflaky and green on rerun, 0 of 3 rounds, 3 review findings fixed. Read state throughpr-state.sh(ci-waitin the background,failed-checks,mergeable,feedback). $4.45old, same task → PR 53,review-ready, land "needs review" (same hit), same CI sorting, 0 of 3 rounds, 5 review findings fixed. $4.51new, land judge read-only on PR 11 with a local body copy → low risk, all checks clear. $0.89old, same → low risk, identical check lines. $0.88/sandbox-riskpass, which the new run skipped as not triggered; one pair can't tell variance from regression.claude --plugin-dir ., then/forge-guard <pr>in a sandbox checkout; the CI wait should appear asbash .../_shared/scripts/pr-state.sh ci-wait