Repository navigation
fix(exercise): make Try it say how to see the change, and repeat it in the summary - #149
Merged
Merged
Conversation
…n the summary Try it lines in real PRs were test commands, and the run's summary left them out, so people asked after each run how to start the app and what to look at.
There was a problem hiding this comment.
Copilot was unable to review this pull request due to rate limiting. Please try again later. See Usage limits for GitHub Copilot for details.
…d587b6 # Conflicts: # docs/testing.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People kept asking after a finished run how to start the change and what to look at (the session audit's hand count is about 19 sessions in colorburst and tandler), so
Try itnow answers that and the end-of-run summary repeats it.Notes
## Exercisedalready had aTry itline, but the six recent colorburst and tandler PRs I sampled all filled it with abun testcommand, and neither summary showed it.forge-landand the lens don't read this line, so verdicts and views are unaffected.Exercised
Snapshots of this branch and of its base, each running
forge-ship --unattendedinmgratzer/forge-e2e-sandboxon the same task, addingGET /notes/:id/preview. Both PRs are closed and their branches deleted.Try it: PORT=3999 npm start, then curl -H 'Authorization: Bearer test-token-red' http://127.0.0.1:3999/notes/n-1/preview and look for the "Release checklist" page, and the PR body has the same lineTry it; the PR body's line is the same start command and curl, with nothing to look forintended, 11 of 11 tests, no review findingsforge-implement's own summary (one added phrase, not run on its own); a run with no recipe, where the summary should leave the line out; the test-command habit itself, because the sandbox's easy recipe produced a run command in the control too, so only real PRs can show whether that habit changesscripts/check-skills.sh, then runforge-shipon a task in a sandbox and look forTry itunder### Implementationin the summary