Repository navigation
Unify pane borders and clarify text entry - #25
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Two moderate-severity issues remain in editor width handling and zero-content Kitty image rendering.
0 open findings
What changed in this PR
This PR standardizes framed content panes, editable-field styling, header behavior, and image layout across the terminal UI.
Changes:
- Adds shared pane geometry and rounded borders.
- Moves search and title inputs into pane headers.
- Refreshes theme-aware input backgrounds.
- Reflows content, mouse targets, and images within pane bounds.
- Adds extensive layout and styling regression tests.
Outstanding findings: composer.go should pass the full inner width to SetWidth; images.go should handle zero-content panes before entering the Kitty image path. Both are moderate-severity findings (1 vote each).
| File | Summary |
|---|---|
README.md |
Documents pane and input styling changes. |
internal/ui/ui.go |
Applies shared pane layout to topic lists. |
internal/ui/ui_test.go |
Updates navigation and style expectations. |
internal/ui/topic.go |
Uses pane geometry for topic content and targets. |
internal/ui/tabs.go |
Supports empty headers and literal rows. |
internal/ui/style.go |
Adds pane, input, and header styling. |
internal/ui/startup_load.go |
Frames startup loading content. |
internal/ui/search_notifications.go |
Frames search and notification views. |
internal/ui/pane.go |
Provides shared pane geometry and drawing. |
internal/ui/pane_test.go |
Tests pane layouts and field backgrounds. |
internal/ui/images.go |
Reflows images within panes; has an outstanding zero-content Kitty-path issue. |
internal/ui/errors.go |
Frames error content. |
internal/ui/composer.go |
Updates editor layout and theme refresh; has an outstanding width-handling issue. |
internal/ui/background_test.go |
Validates background behavior across themes. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header boxes previously used a separate background, and most content views lacked the rounded main-pane border already used by the topic list. This change gives every content view a consistent framed main pane and makes content headers share the main background.
Validation:
go test -race -timeout 10m ./...andgo vet ./...pass.