Repository navigation
Conversation
yordan-st
changed the title
yordan-st
marked this pull request as ready for review
October 22, 2026 09:09
This comment has been minimized.
This comment has been minimized.
yordan-st
force-pushed
the
fix/WC-3630_gallery-refresh-interval
branch
from
October 22, 2026 09:25
e1a15bd to
44bffda
Compare
This comment has been minimized.
This comment has been minimized.
yordan-st
force-pushed
the
fix/WC-3630_gallery-refresh-interval
branch
from
October 22, 2026 09:50
44bffda to
dce857b
Compare
This comment has been minimized.
This comment has been minimized.
The DI container migration hard-coded refreshIntervalMs to 0 and never bound GY.refreshInterval, so the Refresh time property had no effect. Derive the interval from props and bind the token, mirroring Datagrid. Adds container-level regression tests. Ticket: WC-3630
yordan-st
force-pushed
the
fix/WC-3630_gallery-refresh-interval
branch
from
October 23, 2026 10:58
dce857b to
eb307a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Gallery's "Refresh time (in seconds)" property has had no effect since the DI container migration (b5010ee).
galleryConfighard-codedrefreshIntervalMs: 0, and theGY.refreshIntervaltoken injected intoDatasourceServicewas never bound.refreshIntervalMsfromprops.refreshInterval * 1000and bindsGY.refreshIntervalin the query bindings, mirroring Datagrid 2.Found while implementing WC-3362.
What should be covered while testing?