Repository navigation
Explain the removed COORDINATOR privilege where readers hit it - #1872
Open
katarinasupe wants to merge 2 commits into
Open
katarinasupe wants to merge 2 commits into
katarinasupe wants to merge 2 commits into
Conversation
Remove the stale COORDINATOR rows from the query privileges table and add SHOW ROUTING TABLE under COORDINATOR_READ. Say in every callout that the new coordinator privileges aren't a replacement. Add both errors to the auth errors page and list removed privileges on the deprecated features page.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GRANT COORDINATORhas failed with a bare syntax error since Memgraph 3.13 removed theCOORDINATORprivilege (memgraph/memgraph#4399). Only the release notes explained it, and the docs partly contradicted them.COORDINATORrows (including a duplicateSHOW COORDINATOR SETTINGSrow) and listsSHOW ROUTING TABLEunderCOORDINATOR_READ. The callout saidCOORDINATOR_READandCOORDINATOR_WRITEreplacedCOORDINATOR; they don't.GRANT COORDINATORanywhere, andCOORDINATOR_READ/COORDINATOR_WRITEon a data instance.Product PR
None, docs-only change. Ran on Memgraph 3.14.0 in Docker (data instance, with an Enterprise license):
GRANT/DENY/REVOKE COORDINATOR,GRANT COORDINATOR_READ/COORDINATOR_WRITE,GRANT ALL PRIVILEGES,SHOW PRIVILEGES. The error text is from that run. Not run on an HA coordinator; theSHOW ROUTING TABLEprivilege is fromrequired_privileges.cppon master.