Repository navigation
Conversation
|
🎉 This PR is included in version 4.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The code-block editor awaits dynamically loaded language support before creating its CodeMirror view. If the block is removed or its language changes while that promise is pending, the old effect still creates a view. An older load finishing last replaces the current editor with stale code, losing newer visible edits; an unmounted block instead receives an orphaned editor.
Changes
Validation
Based on main
4d9499a86cb797cb92d2a6a4718619983e5955e3.npm run typecheckandnpm run lint: passed.NODE_OPTIONS=--max-old-space-size=1400 npm run build: passed, including declaration rollup. The initial unconstrained build was killed during declaration generation under cloud memory pressure.No dependency, workflow, or public API changes.
CI outcome
CI run 40184410937 completed for head
1e16b00857c1e0d2e178c9d3d109a69ed5604bb7. The overall run is not green.tests/browser/table-image-dialog.spec.ts:68, for cell/root paste uploads that complete after moving to another cell. They fail at line 82 becausewindow.finishTableImageUploadis not a function.The failed test and its
bug-991story are byte-identical to base4d9499a. That story installs only table/image/toolbar plugins and does not mount CodeMirror. The new Vitest mock is confined tosrc/test/codemirror-lifecycle.test.tsx; Playwright runstests/browserin a separate job, and Ladle loadssrc/examples/*.tsx.The existing #995 head
53887ad239839a53c9128d66098310023032c1derestores Firefox's constructor-dropped syntheticclipboardDatain these exact cases and asserts the image payload before dispatch. These facts strongly point to the inherited clipboard fixture issue rather than this CodeMirror change. A pristine-base local rerun was attempted but blocked before page creation byuv_interface_addressesin the Ladle server; it did not execute the baseline assertions. No fixture changes or blind CI reruns were added here.