Repository navigation
Adopt the weekly production Connect repin contract for Reader web - #113
Open
callumalpass wants to merge 1 commit into
Open
callumalpass wants to merge 1 commit into
callumalpass wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design
Reference adoption for the ops weekly train: https://github.com/mdbase-dev/mdbase-cloud-ops/pull/1335 (contract:
docs/weekly-app-repin.md).sdk-repin.ymlwith one requiredconnect_releaseinput. Restrict it to main and serialize repins without cancellation.automation/sdk-repin, updating its bot-owned branch with an exact force-with-lease and enabling normal auto-merge. Existing required app CI gates the merge.deploy-reader.ymlmain production path, retaining its reusable CI, environment, clean-tree/build/served-manifest checks and manual/native paths. No new deployment implementation. Reader's existing production environment already permits main and release/native-production; its main branch currently requiresLint, typecheck, test and build, and repository auto-merge is already enabled. These were read, not changed.Explicit prerequisites / scope
RELEASE_AUTOMATION_CLIENT_ID/RELEASE_AUTOMATION_APP_PRIVATE_KEYavailable to Reader. Missing access fails; no workflow-token fallback. This PR changes no App installation or secrets.Validation
rpnpm test:sdk-repin: 5 tests pass on Node 22.22.0 / pnpm 10.7.0, including exact production identity, preserved aliases/originals, exact pin/no-op planning, unsupported input refusal, and a subprocess fixture proving missing SDK writes nothing before a successful repin/repeat no-op.rpnpm lint:code: passes for the Reader tree.git diff --checkpasses.sdk-repin.yml: actionlint with ShellCheck passes. Modifieddeploy-reader.yml: actionlint syntax/expressions pass; its existing ShellCheck SC2034 unusedattemptwarning remains unchanged.PR-only: no merge or auto-merge enabled on this adoption PR, no publish/deploy workflow dispatched, no environment or release record changed. Work was done in a fresh temporary clone, not a
/home/calluma/projectscheckout.