Repository navigation
test(webui): compare the shell screenshot exactly - #246
Merged
Merged
Conversation
The shell-and-rail screenshot was the only assertion in the package that allowed a difference: `maxDiffPixels: 2`. The allowance was never measured. The commit that added it (4d06e81) also changed the home greeting and the stacking order of the session-row actions. Neither renders into this screenshot. The greeting belongs to the home surface, and this case opens a session; the row actions are `opacity: 0` until their row is hovered or focused, and the case does neither. The baseline was regenerated on the runner's own Chromium at 5dd91b3 and has not been rewritten since, and PR #240's Linux browser gate passed this very baseline with no tolerance at all. Compare the screenshot exactly, the way the other nine baselines are compared.
modacker
force-pushed
the
test/webui-shell-rail-exact-screenshot
branch
from
October 23, 2026 18:32
da6c032 to
bd44182
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell-and-rail screenshot was the only assertion in the package that allowed a difference:
maxDiffPixels: 2. The allowance was never measured.The commit that added it (4d06e81) also changed the home greeting and the stacking order of the session-row actions. Neither renders into this screenshot. The greeting belongs to the home surface, and this case opens a session; the row actions are
opacity: 0until their row is hovered or focused, and the case does neither.The baseline was regenerated on the runner's own Chromium at 5dd91b3 and has not been rewritten since, and PR #240's Linux browser gate (
test:webui-browser => PASS) passed this very baseline with no tolerance at all. Nothing since has touched an element that renders into this screenshot.Compare the screenshot exactly, the way the other nine baselines are compared.
If the gate turns red, the diff artifact carries the exact pixel count, and the baseline can be regenerated on the runner's own Chromium the way 5dd91b3 and ac81d18 did.