Repository navigation
fix(services): Use unix time directly from Ride API - #126
Open
grantlh1122 wants to merge 5 commits into
Open
grantlh1122 wants to merge 5 commits into
grantlh1122 wants to merge 5 commits into
Conversation
jumpy-cat
approved these changes
Oct 27, 2026
jumpy-cat
left a comment
Member
There was a problem hiding this comment.
Code changes look good. Just one small note: the existing test with coverage is actually should have cached preds in a good state. That test had the ride fields commented out for some reason so I've pushed a commit that uncomments them.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Originally the service for getting Ride predictions would estimate the unix time based on the predicted minutes until arrival field. This changes the function to use the unix timestamp from the Ride API instead.
Type of Change
feat)fix)Changed Files
graphBuilder.tsRelated Issues
Subissue of bus notifications tracking issue #33
Does your code rely on another PR
N/A
Testing Done
Flutter:
Vitest:
Screenshots / Demo (if UI or notification change)
Checklist
<type>(scope): short descriptionmainand is our current working update branch (e.g.maizebus2.1,dev)print()/debugPrint()/console.log()left in production code