Repository navigation
feat(caching): namespace every Redis key and channel with CachingOptions:KeyPrefix - #13
Merged
Merged
Conversation
…ons:KeyPrefix Every key the framework writes to Redis was unprefixed (cache entries, HybridCache tag invalidations, the Data Protection key ring, idempotency locks, quota counters) and the SignalR backplane used a fixed `fsh-signalr` channel. Applications or environments sharing one Redis server collided; a defaultDatabase index does not help the backplane, because pub/sub ignores the database. CachingOptions:KeyPrefix (normalized by Core's RedisKeyPrefix) now namespaces all of them: RedisCacheOptions.InstanceName, the Data Protection list key, the idempotency reservation, quota counters (QuotaOptions:KeyPrefix overrides) and the SignalR channel prefix. Empty keeps today's layout. The template ships FSH.Starter / FSH.Starter:prod, renamed per project by sourceName. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # src/BuildingBlocks/Caching/Extensions.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings upstream PR fullstackhero#1450 into the fork.
Conflict in
Caching/Extensions.csresolved by keeping the fork's configurable Data Protection application name and database-store switch, and applying the key prefix to the Redis key-ring key. The fork'sappsettings.jsonalso gets a comment explainingKeyPrefix.Verified on this branch: Framework.Tests 381/381, Caching.Tests 31/31, Architecture.Tests 61/61, Integration.Tests (caching, Data Protection, idempotency) 20/20.
🤖 Generated with Claude Code