Repository navigation
Preserve Scaleway object ACLs during bucket synchronization - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What changes
Ordinary Scaleway bucket synchronization no longer installs a bucket-wide public-read policy, which could override private object ACLs. Storage sync failures also no longer abort an enclosing database transaction when the caller handles the error and continues.
🔎 Additional checks
An isolated API creation scenario completed with an API key using only bucket HEAD and CORS requests, with no policy request. The earlier simulated HTTP 400 scenario also succeeds after the transaction fix. No live storage settings were changed.