Repository navigation
Add an audio description toggle to mave-player - #143
Open
bluebird42 wants to merge 2 commits into
Open
bluebird42 wants to merge 2 commits into
bluebird42 wants to merge 2 commits into
Conversation
When the manifest lists audio_descriptions, HLS playback shows an AD button that switches to the audio rendition marked public.accessibility.describes-video in the current language and back. The choice is remembered per viewer. The descriptions WebVTT is added as a hidden kind="descriptions" track and stays out of the captions menu. A new audiodescription attribute (auto, on, off) controls the button. Includes a local HLS example under examples/audio-description.html.
bluebird42
force-pushed
the
audio-description
branch
from
November 1, 2026 15:48
e9142b1 to
67dc9b5
Compare
Replace the separate AD toggle with the existing audio track selector. Support optional descriptive WebVTT and retain the live HLS audio track count. Keep the current main-branch subtitle fixes and package version.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Core can now publish audio descriptions (maveio/core#39): per language a full-mix MP3 with spoken descriptions, as an HLS alternate audio rendition marked
CHARACTERISTICS="public.accessibility.describes-video", and a descriptions WebVTT, listed in a new manifest key:This PR lets
mave-playerplay them:src/components/audio-description-button.ts) in the control bar, witharia-pressed. On switches to thedescribes-videoaudio track in the current audio language (falling back tovideo.language, thenen); off goes back to the previous track. The choice is remembered per viewer.audiodescriptionattribute:auto(default: shown when the manifest has audio descriptions and playback is HLS),on,off. Not shown for MP4-only playback.<track kind="descriptions">, for assistive technology, and stays out of the captions menu.Embed.audio_descriptionstype insrc/embed/api.ts.examples/audio-description.htmlwith a small local HLS fixture.Manifests without
audio_descriptionsbehave exactly as before.Verified
npm run ts-typesandnpm run buildpass.npm run lintreports no new errors (the changed files had the same count before).