Repository navigation
fix: avoid redundant direction writes in large previews - #197
Merged
Merged
Conversation
Let LTR prose inherit automatic direction when safe, while retaining native per-block detection for RTL text and detached PDF export. Cover mixed scripts, direction changes, technical content, and large-document attribute writes. Fixes #195.
This was referenced Nov 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large chat exports stall while the preview writes
diron every top-level block. Let LTR-only blocks inherit automatic direction when safe, while retaining native per-block detection for RTL text, explicit direction settings, and detached PDF exports.Fixes #195. Thanks to @zenbao for the detailed report and measurements.
Validation:
bun test: 113 tests pass.bun run build: TypeScript and production build pass.The separate full-document rerendering cost remains outside this fix.