PHPStan [no_release] - #104
Closed
james-hill-matomo wants to merge 1 commit into
Closed
james-hill-matomo wants to merge 1 commit into
james-hill-matomo wants to merge 1 commit into
Conversation
Change in VisitorDetails is no-op - is_empty(null) is true.
Contributor
|
Carried across to #133 against 6.x-dev, which is where this plugin's CI now lives. |
snake14
added a commit
that referenced
this pull request
Sep 17, 2026
Carried across from #104, which raised the level and dropped a duplicated is_null() check in VisitorDetails that min() on the line above has already ruled out. That pull request targeted 5.x-dev and predates the shared CI umbrella, so only these two pieces are still wanted. Level 5 then reported an always-true property_exists() on ViewDataTable\Config::$selectable_columns. Its sibling guard on Numeric::$byteSizeUnit goes with it: PHPStan does not flag that one, but the property has been in core since 2022 and is present at 6.0.0-b1, so the comment claiming it may be missing is no longer true of any supported Matomo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change in VisitorDetails is no-op - is_empty(null) is true.
Checklist