Repository navigation
Keep keyboard focus in the accessible Parsons editor - #1952
adamant-pwn wants to merge 3 commits into
Conversation
EJMFarrow
left a comment
There was a problem hiding this comment.
Hi, @adamant-pwn . This will need to be separated out into 2 PRs. The accessible Parsons branch is extremely experimental. I created it for feedback on the first pass of a design and it's been on the backburner every since. Happy to simply merge any related improvements you have into this branch but I haven't even checked the base code of the changes yet.
The input labeling looks like a good idea but is more general. It would be good to have a pull request for that to dev. It's a fairly major design decision, though, so create an issue for it so we can get other people to take a look. I'm wondering if there's a better way to set things up, both from the question authoring perspective (so people are more likely to use it) and the code. We try to keep JS re-wiring of the HTML to a minimum, not least because it needs to be replicated for the API and mobile app. I'll have a think.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0d434ef to
3d18fb7
Compare
|
Thanks, Edmund. I split it as you suggested. This PR now has only the Parsons editor changes, for |
In the keyboard editor of the accessible Parsons block (#1627), each edit rebuilds the controls and keyboard focus is lost. Keyboard and screen-reader users have to find their place again after every step.
With this change:
aria-disabled.Pressing Enter on Add in a local Moodle 5.0 preview, before and after:
The last two commits port CI fixes that
devalready has, so CI runs on this branch.The input labels from the first version of this PR moved to #1960.
I tested with the keyboard in Chromium and with Jest, not with a screen reader. AI-assisted (Codex, Claude Code).
🤖 Generated with Claude Code