You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The statement of near_shiftE and nbhsDl are the same but on different structures that maybe ought to share an interface. This is an observation that has already been done for other lemmas, so maybe this is time to reconsider the hierarchy of mathematical structures to factorize code.
The duplication of code is calling for a more in-depth review (which might end up in adding structures) so we postpone to the next release (fyi: @mkerjean )
Just a thought:
We long had PseudoMetricNormedZmod defined with a numDomainType parameter.
Recently, we have added PseudoMetricNormedZmod0 and made PseudoMetricNormedZmod derive from Metric.
In fact, as a consequence, many lemmas can be changed from PseudoMetricNormedZmod down to PseudoMetricNormedZmod0 without impacting the code.
Which makes me wonder whether we shouldn't make PseudoMetricNormedZmod have a numFieldType as a parameter instead of sticking to numDomainType: this actually comes in the way when trying to refactor the code as hinted at in this conversation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enhancement ✨This issue/PR is about adding new features enhancing the library
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Split from #2023. Depends on #2024 and #2027.
Checklist
CHANGELOG_UNRELEASED.mdadded corresponding documentation in the headersReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers