Skip to content

fix: show alias hovers for quoted table paths - #223

Merged
Light2Dark merged 1 commit into
mainfrom
codex/quoted-alias-hover
Oct 15, 2026
Merged

Light2Dark merged 1 commit into
mainfrom
codex/quoted-alias-hover

Conversation

@Light2Dark

Copy link
Copy Markdown
Member

This pull request was authored by a coding agent.

📝 Summary

  • Hovering u.id in queries using FROM "my.table" u or FROM "my.db".users u fails to show column details because alias lookup flattens quoted identifier boundaries.
  • Resolve alias targets containing literal dots through their existing segmented table paths. Keep ordinary alias lookup behavior and public context types unchanged.
  • Cover quoted table/catalog names alongside colliding nested namespaces, and prevent missing columns from resolving through a different nested table.

📋 Pre-Review Checklist

  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
  • Video or media evidence is provided for any visual changes (optional).

✅ Merge Checklist

  • I have read the contributor guidelines.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Tests have been added for the changes made.

Written by gpt-6 on Codex

@Light2Dark
Light2Dark marked this pull request as ready for review October 15, 2026 04:03
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 93.68% 1720 / 1836
🔵 Statements 93.77% 1778 / 1896
🔵 Functions 94.82% 238 / 251
🔵 Branches 87.61% 1387 / 1583
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/sql/hover.ts 100% 97.83% 100% 100%
Generated in workflow #944 for commit 5d5d7ed by the Vitest Coverage Report Action

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@Light2Dark
Light2Dark merged commit 5d5d7ed into main Oct 15, 2026
6 checks passed
@Light2Dark
Light2Dark deleted the codex/quoted-alias-hover branch October 15, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant