Repository navigation
fix: avoid false schema warnings for quoted dots - #221
Merged
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Light2Dark
marked this pull request as ready for review
October 15, 2026 03:25
4 of 6 tasks
Light2Dark
added a commit
that referenced
this pull request
Oct 15, 2026
**This pull request was authored by a coding agent.** ## 📝 Summary - A column reference such as `"my.table".id` can resolve against `my.table` when both tables occur in a query, producing a false unknown-column warning or missing an invalid column. - Keep database, schema, and table qualifier segments separate through source matching. Single-identifier aliases retain precedence, including aliases that contain dots. - Cover both directions of the quoted-name collision with valid and invalid columns, and require parser success so unsupported syntax cannot silently pass the cases. This follows up the existing limitation identified in [#221](#221 (comment)). ## 📋 Pre-Review Checklist - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/codemirror-sql/discussions) (Please provide a link if applicable). - [x] Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it. - [ ] Video or media evidence is provided for any visual changes (optional). ## ✅ Merge Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/codemirror-sql/blob/main/CONTRIBUTING.md). - [x] Documentation has been updated where applicable, including docstrings for API changes. - [x] Tests have been added for the changes made. > Written by gpt-6 on Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was authored by a coding agent.
📝 Summary
SELECT u.id FROM "my.table" uandSELECT u.id FROM "my.db".users ureceive false schema warnings because the semantic linter splits dots inside quoted identifiers."my.table"resolves independently frommy.table. The change is internal to the semantic linter.📋 Pre-Review Checklist
✅ Merge Checklist