Repository navigation
Conversation
mapping-commons/fair-mappings-schema is now the source of truth for the two transformations and their slot-level SSSOM sets, and the copies here had already drifted from it. registry.yml lists the four files by their https://w3id.org/fair-map/ PURLs, the ETL fetches each one from its mapping_set_id (or mirror_from), and transforms/ and mappings/ go. The registry workflow now runs on changes to registry.yml rather than transforms/, and the README and CONTRIBUTING point at the new home.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapping-commons/fair-mappings-schema is now the source of truth for the two FAIR transformations and their slot-level SSSOM sets (mapping-commons/fair-mappings-schema#23). The copies in
transforms/andmappings/had already drifted from it: old namespace, no creator handling, and the SSSOM set missing two rows.registry.ymllists the four files by their PURLs,https://w3id.org/fair-map/transforms/{sssom,linkmlmap}-to-fairandhttps://w3id.org/fair-map/mappings/{sssom,linkmlmap}-to-fair, instead of thew3id.org/mapping-commons/...ids, which never resolved._process_transform_registryfetches each file from itsmapping_set_id(ormirror_from) rather than looking intransforms/andmappings/, which are removed.build.ymlnow triggers onregistry.ymlinstead oftransforms/**. README and CONTRIBUTING point at fair-mappings-schema, and the "add a new format" steps say to add the transform there and give it a PURL.Merge this last, after mapping-commons/fair-mappings-schema#23 and the w3id PR (perma-id/w3id.org#7147). The push to
registry.ymltriggers the rebuild, and until the PURLs resolve the four entries fail to fetch and drop out ofdata/mapping-specifications.json.I ran
_process_transform_registryon the newregistry.yml, with each PURL served from the file on the fair-mappings-schema branch. All four entries come out with the new ids. I couldn't run the full ETL, becausepyproject.tomlpinsfair-mappingsto an oldadd-clicommit that still hasscoring.py, which the released package no longer ships.