Fix runtime history-transfer deadlocks and Google Chat failure status - #120
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching a thread to
/sudocould hang before engine startup when history transfer needed to rebuild a container: preparation counted the transfer's own lease as another occupant. Pass the lease, cancellation signal and progress callback through the carry path; bound preparation and preserve explicit Stop instead of starting transcript recovery.Google Chat now propagates fatal receiver failures to transport health, stops intake and hides the failed connector. Pub/Sub 403 errors include a Subscriber-role and reconnect hint. Reconnection is protected against late failures from older connections.
Validation:
Remaining acceptance: real-engine conversation cases and private QA registry updates are recorded as pending in TEST-PLAN.md. Google IAM grants are deployment configuration and require the project administrator; the code does not grant cloud permissions. Actual copy execution retains its existing 120-second CLI bound; preparation waits cancel immediately.