Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes invalid normal indices generated by the binary FBX exporter.
PolygonVertexIndex uses FBX negative index encoding to mark the last vertex of each polygon. The binary exporter was also using this modified index array for NormalsIndex, causing the last normal index of every polygon to be negative.
NormalsIndex uses ByPolygonVertex / IndexToDirect mapping, so it should reference the original vertex-normal indices instead of the polygon-termination encoded indices.
This change keeps the negative termination encoding in PolygonVertexIndex unchanged and uses the original face indices for NormalsIndex.
The fix was checked with both triangles and quads. It was also tested by exporting from MakeHuman 1.3.0 and importing the binary FBX into Autodesk 3ds Max, where geometry that previously failed to import correctly was restored.