add sub account deletion - #75
Open
oshchyhol wants to merge 2 commits into
Open
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 8, 2026
oshchyhol
marked this pull request as ready for review
September 8, 2026 09:21
oshchyhol
force-pushed
the
MT-23420-java-delete-sub-account
branch
from
September 9, 2026 11:41
7f92825 to
38f96de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The API gains
DELETE /api/organizations/{organization_id}/sub_accounts/{sub_account_id}. The SDK covers listing and creating sub accounts but not deleting them.Changes
SubAccounts.deleteSubAccount(organizationId, subAccountId)– sends the DELETE request, returns nothing on successSubAccountsExampledeletes the sub account it createsHow to test
client.organizationsApi().subAccounts().deleteSubAccount(orgId, subAccountId)with an existing sub account – returns without an exception, the sub account is gone fromgetSubAccounts(orgId)HttpClientExceptionwith status 404HttpClientExceptionwith status 403HttpClientExceptionwith status 401SubAccountsExamplewithMAILTRAP_API_KEYandMAILTRAP_ORGANIZATION_IDset – it lists sub accounts, creates "Acme Marketing", deletes it and printsSub account <id> deletedmvn javadoc:javadoc– thedeleteSubAccountentry renders inSubAccountsCompanion PRs
Caveat: merge and release only after the backend change ships; the endpoint is not in production yet.