Repository navigation
Conversation
Documentation and tests only; no behaviour changes. - NonSwingHitsCharacterizationTest pins what VanillaWrapperListener does today for hits with no damage request that are not weapon swings: splash potions and area effect clouds, wind charges, fireballs, snowballs and eggs, llama spit, shulker bullets, evoker fangs, tridents, and how true damage is (not) represented. No existing test was touched. - doc/COMBAT_OPEN_QUESTIONS.md gives, per case, the current behaviour with file and line, whether it is plausibly wrong, options and a recommendation. - doc/COMBAT_SERVER_TEST_CHECKLIST.md is the manual real-server plan for the Codex 1.3.0, Divinity 2.0.0 and Fabled release, marking what the automated tests already cover. - The plan and notes link to both. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FaEyTtqZTEVEUC8iNVnMSc
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Investigation, characterization tests and docs only. No behaviour changes.
NonSwingHitsCharacterizationTest(20 tests) pins whatVanillaWrapperListenerdoes today for hits with no Codex request that are not weapon swings: splash potions and area effect clouds, wind charges, fireballs, snowballs and eggs, llama spit, shulker bullets, evoker fangs, tridents, and how true damage is (not) represented.doc/COMBAT_OPEN_QUESTIONS.md: per case, current behaviour with file:line, whether it is plausibly wrong, options and a recommendation, and the pinning test. The maintainers decide from it.doc/COMBAT_SERVER_TEST_CHECKLIST.md: manual real-server plan for Codex 1.3.0, Divinity 2.0.0 and Fabled, with items marked by how well the automated tests already cover them.Characterization tests
No characterization-test expectations changed; tests were only added.
CombatCharacterizationTestand every other existing test are untouched.Findings worth a look
WEAPON_PROJECTILEwith no attacker._vanilla_generic(no defense attached) is the nearest thing.How it was checked
The cause and damager per case were read from Paper 1.21.11 (
CraftEventFactory) and the vanilla 1.21.11 server bytecode. 1.16.5 was not checked; the checklist asks for it.Verification: full
mvn testexits 0 (336 tests, 2 skipped, the existing trident tests). The new tests were shown to fail when the full-attack line and the zero-damage cancel in production code are broken (both reverted).Generated by Claude Code