Repository navigation
Fix Infra label editing and Workspace Members name display - #116
Merged
Merged
Conversation
feat: Show associated Nodes (Used By) for Networks/Security Groups/SSH Keys
Title: feat: Issue CSP temporary credentials from the user menu, require tokens on API proxy routes
Members 목록 응답(user_id, username, role_name 등)에는 firstName/lastName 이 없는데 Name 표시 함수가 둘을 이어 붙여 "undefined undefined" 가 표시됐다. - Name: 이름(firstName/lastName)이 없으면 username 표시 - Id: username 대신 user_id 표시(Name 과 같은 값 중복 해소) - UUID: 응답에 UUID 가 없어 user_id 가 잘못 표시되던 칸을 숨김
fix: Workspaces Members 탭 Name 이 undefined undefined 로 표시되던 문제 수정
- Edit Labels 열기·조회·시스템 라벨 토글·저장·삭제의 labelType 을 mci 에서 infra 로 변경
(tumblebug v0.13.6 은 Infra 라벨을 /label/infra/{uid} 에 두고 Labels 탭도 이를 읽음)
- Label Filter(GetResourcesByLabelSelector)의 labelType 도 infra 로 변경 (mci 는 unsupported label type 응답)
- 저장 시 sys.* 라벨을 다시 보내지 않도록 변경: tumblebug 이 기존 라벨과 병합하므로 그대로 유지되며,
편집기를 연 뒤 바뀐 시스템 라벨 값을 옛 값으로 덮어쓰는 일을 막음
- saveLabels 의 alert 7건을 common/utils/toast showToast 로 교체 (저장·삭제 성공=success, 변경 없음·리소스 미선택=warning, 실패·오류=error) - Edit Labels 진입 시 Infra 미선택 alert 도 warning Toast 로 교체 - Edit Labels 모달의 Add Label 버튼 이름을 Add 로 변경
- 빈 행에 입력하면 새 빈 행을 덧붙이던 input 리스너를 제거, 행 추가는 Add 버튼으로만 - Add 로 만든 행도 삭제 버튼을 표시(시스템 라벨 행만 숨김)하고, 새 행을 화면에 보이게 스크롤한 뒤 Key 입력에 포커스 - 라벨 목록(#label-editor-content)에 max-height 50vh 세로 스크롤을 적용해 행이 많아도 모달이 화면을 넘지 않게 함
fix: Infra 라벨 편집이 보완
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Infra – Edit Labels
mci, so labels added or edited there did not appear in the Infra Labels tab. Opening, loading, the system-label toggle, saving, deleting, and the Label Filter now useinfra.sys.*) are no longer sent on save. Tumblebug merges the new labels with the existing ones, so system labels are kept, and a system label that changed after the editor was opened is no longer overwritten with its old value.alert(). The "Please select an Infra first." message also uses a toast.Add Label). A new empty row is no longer appended while typing. Added rows have a delete button (hidden only for system labels), and the editor scrolls to the new row and focuses its Key field.Workspaces – Members tab
undefined undefined: the Members list response has nofirstName/lastName. Name now shows the full name if present, otherwise the username.