Repository navigation
Fix K8s NodeGroup info display, Node Terminal output, and inherited Platform Roles on Users - #115
Merged
Merged
Conversation
- Auto Scaling 은 CSP 가 보고한 OnAutoScaling 을 그대로 표시한다. 켜진 채 Min = Max 이면 "true (fixed size: Min = Max)" 로 구분하고, Edit Scaling 모달의 Current 줄도 같은 기준으로 맞춘다. 모달 체크박스 규칙(readBackScaling)은 그대로 둔다. - Image / Spec / Key Pair 값이 없을 때 하드코딩된 샘플값 대신 "-" 를 표시한다.
fix: K8s NodeGroup Info 의 Auto Scaling 플래그 표시 보완
- IAM effective-platform-roles(getUserEffectivePlatformRoles)를 api.yaml 에 등록하고 users_api 에 조회 함수 추가 - User Info Platform Roles 에 상속 역할을 출처 그룹과 함께 표시, 삭제 버튼은 직접 부여 역할에만 - 목록 Platform Roles 열도 유효 역할 기준으로 표시(배경 조회) - 역할 추가·삭제, 그룹 배정·해제 후 유효 역할 재조회
$SSH_CLIENT 는 SSH 를 건 쪽 주소라 tumblebug 호스트나 bastion 노드 IP 가 찍혔다. hostname -I 첫 IPv4 값(없으면 ip -4 addr, lo 제외)을 'Connected to: <hostname> / Private IP: <ip>' 로 출력한다.
tumblebug 은 명령이 0 이 아닌 코드로 끝나면 error 에 'Process exited with status N' 을 담는다. 이 경우 stdout/stderr 를 그대로 보여주고 'Command exited with status N' 을 덧붙인다. SSH 접속 실패 등 그 밖의 오류는 기존처럼 connect Error 로 표시한다.
fix: Node Terminal 첫 줄 IP 를 노드 자신의 IP 로 표시하고, 실패한 명령을 접속 오류로 표시하지 않도록 수정
…-roles fix: Users 화면에 그룹에서 상속된 Platform Role 표시
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
K8s NodeGroup
OnAutoScalingflag reported by the CSP instead of the form state (on && max > min). When autoscaling is on with Min = Max, it showstrue (fixed size: Min = Max). Before this change, IBM and NHN showedfalseeven though their autoscaler stays on at a fixed size. TheCurrent:line in the Edit Scaling modal uses the same rule.-when the value is missing. Before, they showed hard-coded sample values (AL2023_x86_64_STANDARD,t3.medium, a sample key ID).Node Terminal
$SSH_CLIENT, which is the address of the side that opened the SSH session (the Tumblebug host, or the bastion node for nodes reached through a bastion). It now prints the node's ownConnected to: <hostname> / Private IP: <ip>. The IP comes fromhostname -I, then fromip -4 addr show scope global, and isunknownif neither returns a value.connect Error: when a command exits with a non-zero code, Tumblebug returnserror: "Process exited with status N"together with stdout/stderr. The console now shows that output and appendsCommand exited with status N. Other errors, such as SSH connection failures, still showconnect Error.Users – Platform Roles
GET /api/users/id/{userId}/effective-platform-roles(direct + group-inherited,source=direct|group:<name>).<role> (via group <group>). The delete button appears only on directly granted roles.conf/api.yaml: addedgetUserEffectivePlatformRoles.Compatibility
effective-platform-roles.conf/api.yamlchange in its bundled copy as well./web/workflow/list) is kept.